I look for versatility when it comes to singers; guys that can scream their lungs out and sing all in the same breath.
Someone mentioned Mikael Akerfeldt, that's pretty dead on there. His clean vocals are bar none some of the finest in metal, and he has a great death metal growl like the stuff he did for Bloodbath.
People don't give Phil Anselmo enough credit. That guy was great on both sides of the coin when he wanted to be.
Barney Greenway's voice is about as pummeling as things get. Plague Rages is a pretty intimidating vocal display of aggression.
Jon Michael Gioe from Majhas shouldn't have vocal chords after recording Stepping into Character. Talk about putting your all into your screaming. Same goes for Josh when he was in Norma Jean, I'm surprised that guy doesn't pass out when he yells.
Tim "Trim Swinger" Singer puts so much of himself in his vocal work. He always makes for a cathartic listen. Too bad Kiss it Goodbye never made it past their debut.
Of course, I have to give it up for my man Daryl Palumbo who can go psycho at the drop of a dime. I've never heard someone go as crazy as he does on Siberian Kiss.
Anneke Van Giersbergen might be the only chick in metal I can tolerate vocally, she always puts forth some fine, more classically aligned stuff.
To switch up speeds, I don't know if people consider him to be rock, but when he was alive, Jeff Buckley had the best male vocals in music. Truly haunting.
I respect guys that can sing (King Diamond, Bruce Dickinson, Geoff Tate etc) but screaming is just so much more taxing on the body. A lot of people can learn to be great singers, but not everyone can learn to scream with the right tone. But, then, I grew up with death metal, so I'm biased.